Conversation
d24302f to
8900fce
Compare
kbukum1
approved these changes
Aug 28, 2025
markhallen
approved these changes
Aug 29, 2025
8900fce to
8b8ff64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR doing?
This PR integrates
GroupDependencySelectorwithCreateGroupUpdatePullRequestto fix the "superset problem" where group PRs were including dependencies outside the group's scope. The integration adds filtering after compilation to ensure group PRs only contain dependencies that belong to the group.Anything worth calling out?
The filtering is implemented in the
dependency_changemethod and gated behind the:group_membership_enforcementfeature flag for backward compatibility. I tested the integration by mockingcompile_all_dependency_changes_forto verify the correct workflow level.How do we know it works?
All 5 new tests pass, confirming that filtering works when enabled and is bypassed when disabled. Existing functionality remains intact (68/68 operation tests pass), so group PRs will now correctly include only dependencies that match the group's criteria.
Checklist